Move ScalarSequenceParser::HandleSequenceEnd to .cc

src/yaml/vectorParser.cc

@@ -11,6 +11,9 @@
 namespace charles {
 namespace yaml {
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
+
 template<typename T>
 bool
 ScalarSequenceParser<T>::HandleScalar(const std::string& anchor,
@@ -49,6 +52,9 @@ ScalarSequenceParser<T>::HandleSequenceEnd(const Parser::Mark& startMark,
     return true;
 }
 
+#pragma clang diagnostic pop
+
+
 Vector3Parser::Vector3Parser(Scene& scene,
                              Parser::Stack& parsers,
                              CallbackFunction onDone)

src/yaml/vectorParser.hh

@@ -54,21 +54,8 @@ struct ScalarSequenceParser
                       const Parser::Mark& startMark,
                       const Parser::Mark& endMark);
 
-    bool
-    HandleSequenceEnd(const Parser::Mark& startMark,
-                      const Parser::Mark& endMark)
-    {
-        /*
-         * XXX: Need to prefix with this-> for some reason. Maybe the
-         * compiler can't figure out the type properly?
-         */
-        this->SetDone(true);
-
-        /* We have a completed vector. Notify the caller. */
-        this->Notify(mVector);
-
-        return true;
-    }
+    bool HandleSequenceEnd(const Parser::Mark& startMark,
+                           const Parser::Mark& endMark);
 
 private:
     VectorType mVector;