From e7fd65672d432c92ba8c4c3abe883b3d7d0e8550 Mon Sep 17 00:00:00 2001
From: Eryn Wells <eryn@erynwells.me>
Date: Sun, 29 Jun 2025 09:18:44 -0700
Subject: [PATCH] [bitboard, board] Make BitBoard::EMPTY and BitBoard::FULL
 public
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Deprecate the methods.

I think I'm undoing a change I made earlier. 🙃
---
 bitboard/src/bitboard.rs | 6 ++++--
 bitboard/src/lib.rs      | 2 +-
 board/src/movement.rs    | 2 +-
 board/src/sight.rs       | 6 +++---
 4 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/bitboard/src/bitboard.rs b/bitboard/src/bitboard.rs
index b9e4c1c..1897de4 100644
--- a/bitboard/src/bitboard.rs
+++ b/bitboard/src/bitboard.rs
@@ -43,13 +43,15 @@ macro_rules! moves_getter {
 }
 
 impl BitBoard {
-    const EMPTY: BitBoard = BitBoard(u64::MIN);
-    const FULL: BitBoard = BitBoard(u64::MAX);
+    pub const EMPTY: BitBoard = BitBoard(u64::MIN);
+    pub const FULL: BitBoard = BitBoard(u64::MAX);
 
+    #[deprecated(note = "Use BitBoard::EMPTY instead")]
     pub const fn empty() -> BitBoard {
         Self::EMPTY
     }
 
+    #[deprecated(note = "Use BitBoard::FULL instead")]
     pub const fn full() -> BitBoard {
         Self::FULL
     }
diff --git a/bitboard/src/lib.rs b/bitboard/src/lib.rs
index 798e51b..12a25ed 100644
--- a/bitboard/src/lib.rs
+++ b/bitboard/src/lib.rs
@@ -14,7 +14,7 @@ pub use direction::IterationDirection;
 macro_rules! bitboard {
     ($($sq:ident)* $(,)?) => {
         {
-            let mut bitboard = $crate::BitBoard::empty();
+            let mut bitboard = $crate::BitBoard::EMPTY;
             $(bitboard.set(chessfriend_core::Square::$sq);)*
             bitboard
         }
diff --git a/board/src/movement.rs b/board/src/movement.rs
index 4fa4381..8cb8be9 100644
--- a/board/src/movement.rs
+++ b/board/src/movement.rs
@@ -13,7 +13,7 @@ impl Board {
         if let Some(piece) = self.get_piece(square) {
             piece.movement(square, self)
         } else {
-            BitBoard::empty()
+            BitBoard::EMPTY
         }
     }
 }
diff --git a/board/src/sight.rs b/board/src/sight.rs
index 81fb120..f6378b2 100644
--- a/board/src/sight.rs
+++ b/board/src/sight.rs
@@ -27,7 +27,7 @@ impl Board {
         if let Some(piece) = self.get_piece(square) {
             piece.sight(square, self)
         } else {
-            BitBoard::empty()
+            BitBoard::EMPTY
         }
     }
 
@@ -41,7 +41,7 @@ impl Board {
         self.friendly_occupancy(color)
             .occupied_squares(&IterationDirection::default())
             .map(|square| self.sight(square))
-            .fold(BitBoard::empty(), BitOr::bitor)
+            .fold(BitBoard::EMPTY, BitOr::bitor)
     }
 
     pub fn active_color_opposing_sight(&self) -> BitBoard {
@@ -60,7 +60,7 @@ impl Board {
                     Some(self.friendly_sight(c))
                 }
             })
-            .fold(BitBoard::empty(), BitOr::bitor)
+            .fold(BitBoard::EMPTY, BitOr::bitor)
     }
 }