From dd0306f67a935708ce8d2882360d76b5632c83e4 Mon Sep 17 00:00:00 2001 From: Eryn Wells Date: Sat, 13 Oct 2018 20:53:08 -0700 Subject: [PATCH] Clean up how the buffer is made; flatten the if tree --- MetaballsKit/Renderer.swift | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/MetaballsKit/Renderer.swift b/MetaballsKit/Renderer.swift index 23bbef7..8bc8b9e 100644 --- a/MetaballsKit/Renderer.swift +++ b/MetaballsKit/Renderer.swift @@ -193,14 +193,18 @@ public class Renderer: NSObject, MTKViewDelegate { guard let field = delegate?.field else { return } + guard let buffer = commandQueue.makeCommandBuffer() else { + return + } + + var didEncode = false + + + buffer.label = "Metaballs Command Buffer" field.update() - if let buffer = commandQueue.makeCommandBuffer(), - let renderPass = view.currentRenderPassDescriptor { - buffer.label = "Metaballs Command Buffer" - var didEncode = false - + if let renderPass = view.currentRenderPassDescriptor { // Render the per-pixel metaballs if let pipeline = pixelPipeline, let encoder = buffer.makeRenderCommandEncoder(descriptor: renderPass) { @@ -230,11 +234,11 @@ public class Renderer: NSObject, MTKViewDelegate { encoder.endEncoding() didEncode = true } - - if didEncode, let drawable = view.currentDrawable { - buffer.present(drawable) - } - buffer.commit() } + + if didEncode, let drawable = view.currentDrawable { + buffer.present(drawable) + } + buffer.commit() } }