eryn/charles
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Return Vector3::Zero for normal if point is not on surface of plane

Browse source
This commit is contained in:
Eryn Wells 2013-09-22 17:43:11 -07:00
parent a13ce45d39
commit 810990cbe9
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/object_plane.cc
View file

@ -95,6 +95,7 @@ Plane::does_intersect(const Ray &ray, float **t)
return nints; return nints;
} }
// TODO: denom could still be 0 here!
float t0 = numer / denom; float t0 = numer / denom;
// If the t value is negative, it's "behind" the origin of the ray, which we don't care about. // If the t value is negative, it's "behind" the origin of the ray, which we don't care about.
@ -149,6 +150,10 @@ Vector3
Plane::compute_normal(const Vector3 &p) Plane::compute_normal(const Vector3 &p)
const const
{ {
if (!point_is_on_surface(p)) {
return Vector3::Zero;
}
// This one's easy since planes are defined by their normals. :) // This one's easy since planes are defined by their normals. :)
return normal; return normal;
} }